Don't create provided namespace #205
Merged
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for Helm 3 introduced creating namespaces because Helm does not do this automatically anymore. However, a regression was introduced that always creates namespaces, even if a dedicated namespace is provided via CLI flag. Signed-off-by: Reinhard Naegele <[email protected]>
unguiculus
force-pushed
the
fix-namespace-use
branch
from
8cbdcd3 to
68c4006
Compare
Signed-off-by: Reinhard Naegele <[email protected]>
Signed-off-by: Reinhard Naegele <[email protected]>
Signed-off-by: Reinhard Naegele <[email protected]>
jlegrone
reviewed
Feb 14, 2020
There was a problem hiding this comment.
Do we also need to avoid namespace deletion here?
chart-testing/pkg/chart/chart.go
Line 645 in 6d0225c
|
@jlegrone Whenever we create a namespace, we should also delete it again. That's what's the case here. So, this is correct IMO. |
jlegrone
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
@unguiculus my bad, I missed that the case I mentioned was in an else block. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Helm 3 introduced creating namespaces
because Helm does not do this automatically anymore.
However, a regression was introduced that always creates
namespaces, even if a dedicated namespace is provided via
CLI flag.
Signed-off-by: Reinhard Naegele [email protected]